cloud-fan commented on a change in pull request #34263:
URL: https://github.com/apache/spark/pull/34263#discussion_r729044292
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
##########
@@ -118,10 +118,11 @@ trait ConstraintHelper {
}
/**
- * Recursively explores the expressions which are null intolerant and
returns all attributes
- * in these expressions.
+ * Recursively explores the expressions which are null intolerant and
returns all
+ * attributes/ExtractValues in these expressions for scalar/nested types
respectively.
*/
- private def scanNullIntolerantAttribute(expr: Expression): Seq[Attribute] =
expr match {
+ private def scanNullIntolerantAttribute(expr: Expression): Seq[Expression] =
expr match {
+ case e: ExtractValue => Seq(e)
Review comment:
shall we make sure it's a chain of `ExtractValue`? e.g., for
`ExtractValue(SomeFunctionReturningStruct)`, we should still go with the old
code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
