kiszk commented on pull request #34267: URL: https://github.com/apache/spark/pull/34267#issuecomment-944848441
@ulysses-you looks good. I believe `Since JVMs are either 4-byte aligned or 8-byte aligned, we check the size of the bytes` is correct now. For future SW and HW platforms, can we add simple test cases for ByteArray that accesses 1, 2, ...., 7, 8 bytes. It would help future porting to new platforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
