HyukjinKwon commented on pull request #34292: URL: https://github.com/apache/spark/pull/34292#issuecomment-945235842
@baibaichen, existing unittests don't test the change. Can you guys describe how you tested this patch? > It looks like Spark assume the lock order is `CalatogManager` => `SessionCatalog`. We implement a new external catalog that could result in reverse order and hence deadlock. It would be easier to follow if the reverse order was necessary in your implementation. Also, please make sure describe them all in PR description (as guided in the PR template) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
