HeartSaVioR commented on a change in pull request #34276:
URL: https://github.com/apache/spark/pull/34276#discussion_r730560753
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerDiskManagerSuite.scala
##########
@@ -158,6 +159,19 @@ class HistoryServerDiskManagerSuite extends SparkFunSuite
with BeforeAndAfter {
assert(manager.approximateSize(50L, true) > 50L)
}
+ test("Should be able to delete a store") {
+ val manager = mockManager()
+ val tempDir = Utils.createTempDir()
+ val deleteStore = PrivateMethod[Unit]('deleteStore)
+ try {
+ manager invokePrivate deleteStore(tempDir)
Review comment:
If the new test is going to test the basic behavior (happy case), I
don't feel it worths to have a new test. It is pretty obvious how it will work
in happy case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
