sunchao commented on a change in pull request #34148:
URL: https://github.com/apache/spark/pull/34148#discussion_r731187473
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/index/SupportsIndex.java
##########
@@ -38,7 +37,8 @@
* Creates an index.
*
* @param indexName the name of the index to be created
- * @param indexType the IndexType of the index to be created
+ * @param indexType the IndexType of the index to be created. If this is not
specified, Spark
Review comment:
nit: "the IndexType of the index to be created" -> "the type of the
index to be created"?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateIndexExec.scala
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import java.util
+
+import scala.collection.JavaConverters._
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.IndexAlreadyExistsException
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.index.SupportsIndex
+import org.apache.spark.sql.connector.expressions.NamedReference
+
+/**
+ * Physical plan node for creating an index.
+ */
+case class CreateIndexExec(
+ table: SupportsIndex,
+ indexName: String,
+ indexType: String,
+ ignoreIfExists: Boolean,
+ columns: Seq[(NamedReference, Map[String, String])],
+ properties: Map[String, String])
+ extends LeafV2CommandExec {
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ val colProperties: Array[util.Map[NamedReference, util.Map[String,
String]]] = columns.map {
+ case (column, map) =>
+ val propMap = new util.HashMap[NamedReference, util.Map[String,
String]]
+ propMap.put(column, map.asJava)
+ propMap
+ }.toArray
+ val (cols, _) = columns.unzip
+ table.createIndex(indexName, indexType, cols.toArray, colProperties,
properties.asJava)
+ } catch {
+ case _: IndexAlreadyExistsException if ignoreIfExists =>
+ logWarning(s"Index ${indexName} already exists. Ignoring.")
Review comment:
maybe print out the table name too
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateIndexExec.scala
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import java.util
+
+import scala.collection.JavaConverters._
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.IndexAlreadyExistsException
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.index.SupportsIndex
+import org.apache.spark.sql.connector.expressions.NamedReference
+
+/**
+ * Physical plan node for creating an index.
+ */
+case class CreateIndexExec(
+ table: SupportsIndex,
+ indexName: String,
+ indexType: String,
+ ignoreIfExists: Boolean,
+ columns: Seq[(NamedReference, Map[String, String])],
+ properties: Map[String, String])
+ extends LeafV2CommandExec {
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ val colProperties: Array[util.Map[NamedReference, util.Map[String,
String]]] = columns.map {
+ case (column, map) =>
+ val propMap = new util.HashMap[NamedReference, util.Map[String,
String]]
+ propMap.put(column, map.asJava)
+ propMap
Review comment:
hmm why we are creating a new `propMap` for every column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
