JoshRosen commented on a change in pull request #34234:
URL: https://github.com/apache/spark/pull/34234#discussion_r731369282
##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -255,9 +255,24 @@ private[spark] object HighlyCompressedMapStatus {
// we expect that there will be far fewer of them, so we will perform
fewer bitmap insertions.
val emptyBlocks = new RoaringBitmap()
val totalNumBlocks = uncompressedSizes.length
- val threshold = Option(SparkEnv.get)
- .map(_.conf.get(config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD))
- .getOrElse(config.SHUFFLE_ACCURATE_BLOCK_THRESHOLD.defaultValue.get)
+ val medianSize: Long = {
+ val sortedSizes = uncompressedSizes.sorted
+ if (totalNumBlocks % 2 == 0) {
+ Math.max((sortedSizes(totalNumBlocks / 2) + sortedSizes(totalNumBlocks
/ 2 - 1)) / 2, 1)
+ } else {
+ Math.max(sortedSizes(totalNumBlocks / 2), 1)
+ }
+ }
Review comment:
It looks like this code is copied form
https://github.com/apache/spark/blob/1b2bb38ecda7c8826bdf7a47f4dde8a60a3378da/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala#L71-L79
Instead of copy-paste duplicating it, I think we should extract the common
code into a `median(long[])` helper method in `org.apache.spark.Utils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
