cloud-fan commented on a change in pull request #30443:
URL: https://github.com/apache/spark/pull/30443#discussion_r731979768
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -326,6 +327,25 @@ case class Join(
hint: JoinHint)
extends BinaryNode with PredicateHelper {
+ override def maxRows: Option[Long] = {
+ joinType match {
+ case Inner | Cross | FullOuter | LeftOuter | RightOuter
+ if left.maxRows.isDefined && right.maxRows.isDefined =>
+ val maxRows = BigInt(left.maxRows.get) * BigInt(right.maxRows.get)
Review comment:
This is wrong, if one side is empty, the join result is not always empty
for outer join.
It should be `product + sth`, `sth` = if (leftOuter) left.maxRows else if
(rightOuter) right.maxRows else if (fullOuter) (left.maxRows + right.maxRows)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
