cloud-fan commented on a change in pull request #34336:
URL: https://github.com/apache/spark/pull/34336#discussion_r732389211
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -383,8 +383,16 @@ case class Join(
override def maxRows: Option[Long] = {
joinType match {
case Inner | Cross | FullOuter | LeftOuter | RightOuter
- if left.maxRows.isDefined && right.maxRows.isDefined =>
- val maxRows = BigInt(left.maxRows.get) * BigInt(right.maxRows.get)
+ if left.maxRows.isDefined && right.maxRows.isDefined =>
+ val leftMaxRows = BigInt(left.maxRows.get)
+ val rightMaxRows = BigInt(right.maxRows.get)
+ val maxRows = joinType match {
Review comment:
how about
```
val minRows = joinType match {
case LeftOuter => leftMaxRows
...
case FullOuter => leftMaxRows + rightMaxRows
case _ => BigInt(0)
}
(leftMaxRows * rightMaxRows).max(minRows)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
