huaxingao commented on a change in pull request #34291:
URL: https://github.com/apache/spark/pull/34291#discussion_r732437205
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -274,6 +278,11 @@ private[jdbc] class JDBCRDD(
}
}
+ /**
+ * A LIMIT clause representing pushed-down limit.
+ */
+ private def getLimitClause: String = if (limit > 0 ) s"LIMIT $limit" else ""
Review comment:
`LIMIT` is so commonly used and I thought it's a standard SQL, but
unfortunately it turned out not to be the case. I will take care of the dialect
for different databases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
