dongjoon-hyun commented on a change in pull request #34337:
URL: https://github.com/apache/spark/pull/34337#discussion_r732446512
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java
##########
@@ -96,7 +98,12 @@ public float getProgress() throws IOException {
@Override
public boolean nextKeyValue() throws IOException {
- return nextBatch();
+ try {
Review comment:
This looks like adding exceptionally rare-case to the hot-code-path.
Sorry, but I'm -1 for adding this kind of overhead just for a log here,
@AngersZhuuuu .
We already have a info log at `compute` method. Is it insufficient?
```
logInfo("Input split: " + split.serializableHadoopSplit)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
