Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5886#discussion_r29956007
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -215,12 +213,24 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
             })
           }
     
    -      lastModifiedTime = newLastModifiedTime
    +      lastScanTime = newLastScanTime
         } catch {
           case e: Exception => logError("Exception in checking for event log 
updates", e)
         }
       }
     
    +  private def getNewLastScanTime(): Long = {
    +    val fileName = "." + UUID.randomUUID().toString
    +    val path = new Path(logDir, fileName)
    +    val fos = fs.create(path)
    +    fos.close()
    +
    +    val newLastScanTime = fs.getFileStatus(path).getModificationTime
    +    fs.delete(path)
    --- End diff --
    
    You need this line to be in a `finally` block after the `fs.create()` call. 
Something like:
    
        val fileName = "." + UUID.randomUUID().toString
        val path = new Path(logDir, fileName)
        val fos = fs.create(path)
        val newLastScanTime =
          try {
            fos.close()
            fs.getFileStatus(path).getModificationTime
          } finally {
            fs.delete(path)
          }
          


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to