cloud-fan commented on a change in pull request #34291:
URL: https://github.com/apache/spark/pull/34291#discussion_r732567591
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -225,6 +225,25 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
withProjection
}
+ def applyLimit(plan: LogicalPlan): LogicalPlan = plan.transform {
+ case globalLimit @ Limit(IntegerLiteral(limitValue),
DataSourceV2ScanRelation(_, scan, _)) =>
Review comment:
Some more thoughts: it's possible that only the local limit is pushed
down and reaches the scan node, and it should be still useful to push the local
limit.
maybe the API should be `boolean pushLimit(int limit, boolean isGlobal)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
