zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r733085834
##########
File path: dev/lint-python
##########
@@ -124,39 +125,76 @@ function pycodestyle_test {
fi
}
-function mypy_test {
- local MYPY_REPORT=
- local MYPY_STATUS=
- if ! hash "$MYPY_BUILD" 2> /dev/null; then
- echo "The $MYPY_BUILD command was not found. Skipping for now."
- return
+function mypy_annotation_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
+
+ echo "starting mypy annotations test..."
+ PYTEST_REPORT=$( ($MYPY_BUILD \
+ --config-file python/mypy.ini \
+ --cache-dir /tmp/.mypy_cache/ \
Review comment:
If we set `--cache-dir` here explicitly, we can reuse cached for the
data tests.
Alternatively, we can use `$PWD` as the `--mypy-testing-base` in the data
tests, but I'd prefer to avoid that, because temporary files are written there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
