RussellSpitzer opened a new pull request #34343: URL: https://github.com/apache/spark/pull/34343
What changes were proposed in this pull request? Previously CustomMetrics use Class.getCanonicalName when attempting to get the class name of CustomMetric implementations. These names replace special characters for marking inner classes like ($) with ".". While those names are appropriate for referring to classes within source files, they will not work during reflection where the Class.getName output should be used. Why are the changes needed? InnerClasses could never be found in when they are used as Custom Metrics Does this PR introduce any user-facing change? No How was this patch tested? Tests modified so they access both an independent metric class as well as an inner class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
