HyukjinKwon commented on a change in pull request #34349: URL: https://github.com/apache/spark/pull/34349#discussion_r733283876
########## File path: .github/PULL_REQUEST_TEMPLATE ########## @@ -45,4 +45,5 @@ If no, write 'No'. If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. +If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. Review comment: ```suggestion If benchmark tests were added, please run the benchmarks via GitHub Actions, see also https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
