huaxingao commented on a change in pull request #34311:
URL: https://github.com/apache/spark/pull/34311#discussion_r733377718



##########
File path: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/PostgresIntegrationSuite.scala
##########
@@ -49,6 +49,8 @@ class PostgresIntegrationSuite extends 
DockerJDBCIntegrationSuite with V2JDBCTes
   override def sparkConf: SparkConf = super.sparkConf
     .set("spark.sql.catalog.postgresql", classOf[JDBCTableCatalog].getName)
     .set("spark.sql.catalog.postgresql.url", db.getJdbcUrl(dockerIp, 
externalPort))
+    .set("spark.sql.catalog.postgresql.pushDownTableSample", "true")

Review comment:
       It should work if you make parquet scan or csv scan implement the 
interface `SupportsPushDownTableSample`, but I am not sure how parquet or csv 
handles sample.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to