Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5838#discussion_r29964329
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
 ---
    @@ -541,4 +541,21 @@ class FilterPushdownSuite extends PlanTest {
     
         comparePlans(optimized, originalQuery)
       }
    +
    +  test("push down project") {
    --- End diff --
    
    This name is very generic.  `push project past sort` perhaps.  please also 
add a test where the push down would be invalid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to