ueshin commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r734910279
##########
File path: dev/lint-python
##########
@@ -124,10 +125,66 @@ function pycodestyle_test {
fi
}
-function mypy_test {
+
+function mypy_annotation_test {
local MYPY_REPORT=
local MYPY_STATUS=
+ echo "starting mypy annotations test..."
+ MYPY_REPORT=$( ($MYPY_BUILD \
+ --config-file python/mypy.ini \
+ --cache-dir /tmp/.mypy_cache/ \
+ python/pyspark) 2>&1)
+ MYPY_STATUS=$?
+
+ if [ "$MYPY_STATUS" -ne 0 ]; then
+ echo "annotations failed mypy checks:"
+ echo "$MYPY_REPORT"
+ echo "$MYPY_STATUS"
+ exit "$MYPY_STATUS"
+ else
+ echo "annotations passed mypy checks."
+ echo
+ fi
+}
+
+
+function mypy_data_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
+
+ echo "starting mypy data test..."
+
+ if [ "$(pip freeze | grep -c pytest-mypy-plugins )" -eq 0 ]; then
+ echo "pytest-mypy-plugins missing. Skipping for now."
+ return
+ fi
+
+ PYTEST_REPORT=$( (MYPYPATH=python $PYTEST_BUILD \
+ -c python/pyproject.toml \
+ --rootdir python \
+ --mypy-only-local-stub \
+ --mypy-ini-file python/mypy.ini \
+ python/pyspark ) 2>&1)
+
+ PYTEST_STATUS=$?
+
+ if [ "$PYTEST_STATUS" -ne 0 ]; then
+ echo "annotations failed data checks:"
+ echo "$PYTEST_REPORT"
+ echo "$PYTEST_STATUS"
+ exit "$PYTEST_STATUS"
+ else
+ echo "annotations passed data checks."
+ echo
+ fi
+}
+
+
+function mypy_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
Review comment:
We don't need these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
