srowen commented on a change in pull request #34351:
URL: https://github.com/apache/spark/pull/34351#discussion_r734914681
##########
File path:
core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala
##########
@@ -149,17 +149,12 @@ class OpenHashMap[K : ClassTag, @specialized(Long, Int,
Double) V: ClassTag](
}
}
- // The following member variables are declared as protected instead of
private for the
- // specialization to work (specialized class extends the non-specialized one
and needs access
- // to the "private" variables).
- // They also should have been val's. We use var's because there is a Scala
compiler bug that
Review comment:
Is there any way to check that the specialization still works - it would
show up as a bunch of synthetic impl classes in the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
