dchvn commented on a change in pull request #34363:
URL: https://github.com/apache/spark/pull/34363#discussion_r734920972
##########
File path: python/pyspark/accumulators.py
##########
@@ -264,7 +281,12 @@ def authenticate_and_accum_updates():
class AccumulatorServer(SocketServer.TCPServer):
- def __init__(self, server_address, RequestHandlerClass, auth_token):
+ def __init__(
+ self,
+ server_address: Tuple[str, int],
+ RequestHandlerClass: Type["socketserver.BaseRequestHandler"],
Review comment:
I think we need ```class``` type for ```RequestHandlerClass``` so
```Type["socketserver.BaseRequestHandler"]``` is appropriate.
As I know:
```Type[socketserver.BaseRequestHandler]``` for class
```socketserver.BaseRequestHandler ``` for instance
Did I misunderstand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
