tanelk commented on a change in pull request #33404:
URL: https://github.com/apache/spark/pull/33404#discussion_r735157813
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregates.scala
##########
@@ -47,6 +47,10 @@ object RemoveRedundantAggregates extends Rule[LogicalPlan]
with AliasHelper {
} else {
newAggregate
}
+
+ case agg @ Aggregate(groupingExps, _, j: Join) if agg.groupOnly &&
Review comment:
Does it have to be join specific? it looks like it should be able to
handle any nodes. Ideally could remove the entire `case upper @ Aggregate(_,
_, lower: Aggregate)` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
