LuciferYang edited a comment on pull request #34368:
URL: https://github.com/apache/spark/pull/34368#issuecomment-950578362


   @dongjoon-hyun 
   
   > I need to ask about that this works with Java8 build and Java17 run too, 
@LuciferYang . Could you be clear for both cases: Java8 build + Java17 run and 
Java17 build + Java17 run.
   
   > Manual test use Java 17
   > mvn clean install -pl repl -am -DskipTests
   > mvn clean install -pl repl
   
   
   I tested these two scenarios, and they both passed the test. I also added 
them to the PR description
   
   - Manual test use Java17 build + Java17 run (both openjdk version "17" 
2021-09-14 LTS)
   
   Use Java 17 to run the following two commands
   
   ```
   mvn clean install -pl repl -am -DskipTests
   mvn test -pl repl
   ```
   
   **Before**
   
   ```
   Run completed in 30 seconds, 826 milliseconds.
   Total number of tests run: 42
   Suites: completed 6, aborted 0
   Tests: succeeded 33, failed 9, canceled 0, ignored 0, pending 0
   *** 9 TESTS FAILED ***
   ```
   
   **After**
   
   ```
   Run completed in 45 seconds, 86 milliseconds.
   Total number of tests run: 44
   Suites: completed 7, aborted 0
   Tests: succeeded 44, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```
   
   - Manual test use Java8 build + Java17 run 
   
   Use Java 8(openjdk version "1.8.0_292") to run the build command:
   ```
   mvn clean install -pl repl -am -DskipTests
   ```
   
   And Java 17(openjdk version "17" 2021-09-14 LTS) to run the test command:
   ```
   mvn test -pl repl
   ```
   
   **Before**
   ```
   Run completed in 41 seconds, 855 milliseconds.
   Total number of tests run: 44
   Suites: completed 7, aborted 0
   Tests: succeeded 35, failed 9, canceled 0, ignored 0, pending 0
   *** 9 TESTS FAILED ***
   
   ```
   
   **After**
   
   ```
   Run completed in 44 seconds, 596 milliseconds.
   Total number of tests run: 44
   Suites: completed 7, aborted 0
   Tests: succeeded 44, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to