yoda-mon commented on a change in pull request #34356:
URL: https://github.com/apache/spark/pull/34356#discussion_r735348741
##########
File path: python/pyspark/sql/tests/test_functions.py
##########
@@ -241,6 +241,14 @@ def test_dayofweek(self):
row = df.select(dayofweek(df.date)).first()
self.assertEqual(row[0], 2)
+ def test_make_date(self):
+ from pyspark.sql.functions import make_date
Review comment:
I think it's better to move this declaration to the top.
(It's a little bit confusing but the declarations for newly added functions
are written on the top part, like `cot`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
