cloud-fan commented on a change in pull request #34241:
URL: https://github.com/apache/spark/pull/34241#discussion_r735702215
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -634,6 +636,9 @@ private[hive] class HiveClientImpl(
val matchingParts =
specs.flatMap { s =>
assert(s.values.forall(_.nonEmpty), s"partition spec '$s' is invalid")
+ // Since Spark can't know the actual num of matching partitions,
+ // here Spark update hive client calls one by one.
Review comment:
I think it's clearer to say:
```
// For each partition spec, we need to do a Hive client call
// to get the matching partitions/
```
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -634,6 +636,9 @@ private[hive] class HiveClientImpl(
val matchingParts =
specs.flatMap { s =>
assert(s.values.forall(_.nonEmpty), s"partition spec '$s' is invalid")
+ // Since Spark can't know the actual num of matching partitions,
+ // here Spark update hive client calls one by one.
Review comment:
I think it's clearer to say:
```
// For each partition spec, we need to do a Hive client call
// to get the matching partitions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
