zero323 commented on a change in pull request #34375:
URL: https://github.com/apache/spark/pull/34375#discussion_r736454891
##########
File path: python/pyspark/status.py
##########
@@ -19,6 +19,10 @@
__all__ = ["SparkJobInfo", "SparkStageInfo", "StatusTracker"]
+from typing import Optional, List
+
+from py4j.java_gateway import JavaObject
Review comment:
To indicate, that we don't expect this stuff to typecheck at all.
This stays in contrast to other libraries we use, that might or might not
type check depending on the version and / or availability of the 3rd party type
hints (and, possibly, plugins)
> dev/lint-python has passed.
`dev/lint-python` should pass, because we this in the configuration
https://github.com/apache/spark/blob/6d3cfed0e8ab2812bc44bfcd5b82d8d227e77a29/python/mypy.ini#L116-L117
That being said, mypy integrity checks can detect only some categories of
problems. Data tests can do more, but still depend on having negative test
cases in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
