itholic commented on a change in pull request #34389:
URL: https://github.com/apache/spark/pull/34389#discussion_r737070066
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -6879,6 +6912,9 @@ def sort_values(
4 D 7 2
3 None 8 4
"""
+ log_advice(
+ "`sort_values` is expensive. Be aware of use it unless it is
absolutely necessary."
Review comment:
What about `sort_index`?
If we don't issue the advice for `sort_values`, should we neither for
`sort_index`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
