HyukjinKwon commented on a change in pull request #34424:
URL: https://github.com/apache/spark/pull/34424#discussion_r738934580
##########
File path: python/pyspark/files.py
##########
@@ -30,29 +35,32 @@ class SparkFiles(object):
instances.
"""
- _root_directory = None
- _is_running_on_worker = False
- _sc = None
+ _root_directory: ClassVar[Optional[str]] = None
+ _is_running_on_worker: ClassVar[bool] = False
+ _sc: ClassVar[Optional["SparkContext"]] = None
Review comment:
we don't have to type private vars. but I guess mypy complained about
the return type? It's fine then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
