AngersZhuuuu commented on pull request #34412: URL: https://github.com/apache/spark/pull/34412#issuecomment-954594988
> > It's not registered in FunctionRegistry, so should not need to add this? > > @AngersZhuuuu I mean the examples: > > https://github.com/apache/spark/blob/cc4463e818749faaf648ec71699d1e2fd3828c3f/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala#L66-L70 > > Also, could you change the comments: > > https://github.com/apache/spark/blob/cc4463e818749faaf648ec71699d1e2fd3828c3f/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala#L54-L55 > > > since the expression accepts not only numeric column. > The same for `Percentile`. Sorry for my misunderstood. update the desc of column type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
