srowen commented on a change in pull request #34448:
URL: https://github.com/apache/spark/pull/34448#discussion_r739653781
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -620,8 +620,17 @@ abstract class CastBase extends UnaryExpression with
TimeZoneAwareExpression wit
buildCast[UTF8String](_, s => if (s.toInt(result)) result.value else
null)
case BooleanType =>
buildCast[Boolean](_, b => if (b) 1 else 0)
+ case DateType if ansiEnabled =>
Review comment:
I might be missing something but will this branch ever execute? the case
DateType above would seem to cover this case too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
