sarutak commented on a change in pull request #34356:
URL: https://github.com/apache/spark/pull/34356#discussion_r739672789
##########
File path: python/pyspark/sql/functions.py
##########
@@ -2131,6 +2131,32 @@ def weekofyear(col: "ColumnOrName") -> Column:
return Column(sc._jvm.functions.weekofyear(_to_java_column(col)))
+def make_date(year: "ColumnOrName", month: "ColumnOrName", day:
"ColumnOrName") -> Column:
+ """
+ Returns a column with a date built from the year, month and day columns.
+
+ .. versionadded:: 3.3.0
+
+ Parameters
+ ----------
+ year : :class:`ColumnOrName` with the year to build the date
Review comment:
Type hints should be `ColumnOrName` but the type for each parameter
should be ``` `~pyspark.sql.Column` or str ``` here.
Also, please place the description of each parameter in the next line with
indentation like
```
year : class:`~pyspark.sql.Column` or str
The year to build the date.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
