cloud-fan commented on a change in pull request #34451:
URL: https://github.com/apache/spark/pull/34451#discussion_r739967712
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/ScanBuilder.java
##########
@@ -23,7 +23,7 @@
* An interface for building the {@link Scan}. Implementations can mixin
SupportsPushDownXYZ
* interfaces to do operator push down, and keep the operator push down result
in the returned
* {@link Scan}. When pushing down operators, the push down order is:
- * filter -> aggregate -> limit -> column pruning.
+ * filter -> aggregate -> sample -> limit -> column pruning.
Review comment:
shouldn't the sample be the first one? We should follow the natural plan
node order of a `SELECT ... FROM ...` statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
