allisonwang-db commented on a change in pull request #34402:
URL: https://github.com/apache/spark/pull/34402#discussion_r740540249
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -687,10 +687,10 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
case inSubqueryOrExistsSubquery =>
plan match {
- case _: Filter | _: SupportsSubquery | _: Join => // Ok
+ case _: SupportsSubquery | _: Join | _: UnaryNode => // Ok
Review comment:
How to make sure that all UnaryNode can support IN/EXISTS subqueries
(correlated and uncorrelated)? The test cases only covered Project, Aggregate,
and Window. Maybe we could either only support these three nodes for now, or
add more tests to cover other unary operators.
Also, would it work with Aggregate having correlated IN/EXISTS subqueries in
the GROUP BY clause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
