LuciferYang commented on a change in pull request #32648:
URL: https://github.com/apache/spark/pull/32648#discussion_r740814443
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -57,7 +57,8 @@ private[spark] class BasicDriverFeatureStep(conf:
KubernetesDriverConf)
// The memory overhead factor to use. If the user has not set it, then use a
different
// value for non-JVM apps. This value is propagated to executors.
private val overheadFactor =
- if (conf.mainAppResource.isInstanceOf[NonJVMResource]) {
+ if (conf.mainAppResource.isInstanceOf[PythonMainAppResource] ||
Review comment:
```
[ERROR] [Error]
/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala:60:
fruitless type test: a value of type
org.apache.spark.deploy.k8s.submit.MainAppResource cannot also be a
org.apache.spark.deploy.k8s.submit.NonJVMResource
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
