cloud-fan commented on a change in pull request #34451:
URL: https://github.com/apache/spark/pull/34451#discussion_r741619550
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -370,6 +371,10 @@ abstract class JdbcDialect extends Serializable with
Logging{
* returns whether the dialect supports limit or not
*/
def supportsLimit(): Boolean = true
+
+ def supportsTableSample: Boolean = false
+
+ def getTableSample(sample: TableSampleInfo): String = ""
Review comment:
shall we throw `UnsupportedOperationException` by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
