hvanhovell commented on a change in pull request #34474:
URL: https://github.com/apache/spark/pull/34474#discussion_r742398645
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
##########
@@ -226,7 +226,7 @@ object ApproximatePercentile {
*
* @param summaries underlying probabilistic data structure
[[QuantileSummaries]].
*/
- class PercentileDigest(private var summaries: QuantileSummaries) {
+ class PercentileDigest(private var summaries: QuantileSummaries) extends
Serializable {
Review comment:
Can we just add the proper logic to observe? Adding serialization will
fix this particular problem, but it won't work for other aggregates.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
##########
@@ -226,7 +226,7 @@ object ApproximatePercentile {
*
* @param summaries underlying probabilistic data structure
[[QuantileSummaries]].
*/
- class PercentileDigest(private var summaries: QuantileSummaries) {
+ class PercentileDigest(private var summaries: QuantileSummaries) extends
Serializable {
Review comment:
I probably forgot to add it...
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
##########
@@ -226,7 +226,7 @@ object ApproximatePercentile {
*
* @param summaries underlying probabilistic data structure
[[QuantileSummaries]].
*/
- class PercentileDigest(private var summaries: QuantileSummaries) {
+ class PercentileDigest(private var summaries: QuantileSummaries) extends
Serializable {
Review comment:
Can we just add the proper logic to observe? Adding serialization will
fix this particular problem, but it won't work for other aggregates.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
##########
@@ -226,7 +226,7 @@ object ApproximatePercentile {
*
* @param summaries underlying probabilistic data structure
[[QuantileSummaries]].
*/
- class PercentileDigest(private var summaries: QuantileSummaries) {
+ class PercentileDigest(private var summaries: QuantileSummaries) extends
Serializable {
Review comment:
I probably forgot to add it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
