Peng-Lei commented on pull request #34476: URL: https://github.com/apache/spark/pull/34476#issuecomment-960490762
> If you have such tests, please, place them to a separate test suite but not to `*ParserSuite`. Actually, I planned to do so if I would work on unifying of v1 and v2 `CREATE TABLE` tests. @MaxGekk , Could you continue to look at it, and I made the following modifications 1. I define the `PlanResolutionSuiteBase` that contains the properties and methods of `PlanResolutionSuite`. 2. Define the `v1.ShowTblPropertiesPlanResolutionSuite` and `v2.ShowTblPropertiesPlanResolutionSuite` extends the `PlanResolutionSuiteBase`, so that they can use method of parent class. 3. In order to guarantee `PlanResolutionSuite` is right that after extract method/properties to `properties `, I change that `PlanResolutionSuite` extends `PlanResolutionSuiteBase`. 4. `PlanResolutionSuiteBase` may not be abstract enough, but enough for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
