sarutak commented on a change in pull request #34484:
URL: https://github.com/apache/spark/pull/34484#discussion_r743325893



##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
         """
         return self._jdf.isStreaming()
 
+    def isEmpty(self) -> bool:
+        """Returns ``True`` if this :class:`DataFrame` is empty.
+
+        .. versionadded:: 3.3.0
+
+         Examples
+        --------
+        >>> df_empty = spark.createDataFrame([], 'a STRING')
+        >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+

Review comment:
       No blank lines necessary. Otherwise, the example section in the document 
build from the docstring is split.
   
![isEmpty-example-split](https://user-images.githubusercontent.com/4736016/140441029-b81a6f2e-b0bd-4b78-ab0d-490af45f3b9d.png)
   
   Please confirm the layout of the document by `make html` in `python/docs`.
   See also 
http://spark.apache.org/docs/latest/api/python/development/index.html

##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
         """
         return self._jdf.isStreaming()
 
+    def isEmpty(self) -> bool:
+        """Returns ``True`` if this :class:`DataFrame` is empty.
+
+        .. versionadded:: 3.3.0
+
+         Examples
+        --------
+        >>> df_empty = spark.createDataFrame([], 'a STRING')
+        >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+

Review comment:
       No blank lines is necessary. Otherwise, the example section in the 
document build from the docstring is split.
   
![isEmpty-example-split](https://user-images.githubusercontent.com/4736016/140441029-b81a6f2e-b0bd-4b78-ab0d-490af45f3b9d.png)
   
   Please confirm the layout of the document by `make html` in `python/docs`.
   See also 
http://spark.apache.org/docs/latest/api/python/development/index.html

##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
         """
         return self._jdf.isStreaming()
 
+    def isEmpty(self) -> bool:
+        """Returns ``True`` if this :class:`DataFrame` is empty.
+
+        .. versionadded:: 3.3.0
+
+         Examples
+        --------
+        >>> df_empty = spark.createDataFrame([], 'a STRING')
+        >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+

Review comment:
       No blank lines are necessary. Otherwise, the example section in the 
document build from the docstring is split.
   
![isEmpty-example-split](https://user-images.githubusercontent.com/4736016/140441029-b81a6f2e-b0bd-4b78-ab0d-490af45f3b9d.png)
   
   Please confirm the layout of the document by `make html` in `python/docs`.
   See also 
http://spark.apache.org/docs/latest/api/python/development/index.html

##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -473,6 +473,23 @@ def isStreaming(self) -> bool:
         """
         return self._jdf.isStreaming()
 
+    def isEmpty(self) -> bool:
+        """Returns ``True`` if this :class:`DataFrame` is empty.
+
+        .. versionadded:: 3.3.0
+
+         Examples
+        --------
+        >>> df_empty = spark.createDataFrame([], 'a STRING')
+        >>> df_non_empty = spark.createDataFrame([("a")], 'STRING')
+

Review comment:
       No blank lines are necessary. Otherwise, the example section in the 
document built from the docstring is split.
   
![isEmpty-example-split](https://user-images.githubusercontent.com/4736016/140441029-b81a6f2e-b0bd-4b78-ab0d-490af45f3b9d.png)
   
   Please confirm the layout of the document by `make html` in `python/docs`.
   See also 
http://spark.apache.org/docs/latest/api/python/development/index.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to