cloud-fan commented on a change in pull request #29810:
URL: https://github.com/apache/spark/pull/29810#discussion_r743065778
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala
##########
@@ -183,10 +182,10 @@ class UnwrapCastInBinaryComparisonSuite extends PlanTest
with ExpressionEvalHelp
}
test("unwrap cast should skip when expression is non-deterministic or
foldable") {
- Seq(positiveInt, negativeInt).foreach(v => {
- val e = Cast(First(f, ignoreNulls = true), IntegerType) <=> v
+ Seq(positiveLong, negativeLong).foreach (v => {
+ val e = Cast(SparkPartitionID(), LongType) <=> v
Review comment:
can we use `Rand`?
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateDistinctSuite.scala
##########
@@ -39,11 +39,15 @@ class EliminateDistinctSuite extends PlanTest {
Min(_),
BitAndAgg(_),
BitOrAgg(_),
+ First(_, ignoreNulls = true),
+ First(_, ignoreNulls = false),
+ Last(_, ignoreNulls = true),
+ Last(_, ignoreNulls = false),
CollectSet(_: Expression)
).foreach {
aggBuilder =>
val agg = aggBuilder('a)
- test(s"Eliminate Distinct in ${agg.prettyName}") {
+ test(s"Eliminate Distinct in ${agg.toString}") {
Review comment:
nit: just $agg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
