Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5963#discussion_r29996208
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -240,12 +242,24 @@ private[hive] object HiveQl {
* Otherwise, there will be Null pointer exception,
* when retrieving properties form HiveConf.
*/
- val hContext = new Context(new HiveConf())
+ val hContext = new Context(hiveConf)
val node = ParseUtils.findRootNonNullToken((new
ParseDriver).parse(sql, hContext))
hContext.clear()
node
}
+ /**
+ * Returns the HiveConf
+ * TODO get it from HiveContext?
+ */
+ private[this] def hiveConf(): HiveConf = {
--- End diff --
@nitin2goyal what do you think of this implementation? I think it will
also give you the speed up you are looking for as long as you are parsing
queries with a HiveContext. It also has the advantage of using and conf
options that are SET by the user.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
