c21 commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744078327
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
@huaxingao - ah yes I forgot about the test. I am leaving
`RowDataSourceScanExec` as it is for now, and we can discuss later, thanks for
comment @sunchao and @huaxingao.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]