c21 commented on a change in pull request #34499:
URL: https://github.com/apache/spark/pull/34499#discussion_r744185374
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanSuite.scala
##########
@@ -109,4 +113,19 @@ class SparkPlanSuite extends QueryTest with
SharedSparkSession {
assert(err.getMessage.contains("Deduplicate operator for non streaming
data source " +
"should have been replaced by aggregate in the optimizer"))
}
+
+ test("SPARK-37221: The collect-like API in SparkPlan should support columnar
output") {
+ val results = ColumnarOp(LocalTableScanExec(Nil, Nil)).executeCollect()
+ assert(results.isEmpty)
Review comment:
I think we are pretty sure this PR change is correct, but shall we add
another test case to double check the non-empty result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
