cxzl25 commented on a change in pull request #34493:
URL: https://github.com/apache/spark/pull/34493#discussion_r744294467
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2642,6 +2642,35 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-37217 Dynamic partitions should fail quickly " +
+ "when writing to external tables to prevent data deletion") {
+ withTable("test") {
+ withTempDir { f =>
+ sql("CREATE EXTERNAL TABLE test(id int) PARTITIONED BY (p1 string, p2
string) " +
+ s"STORED AS PARQUET LOCATION '${f.getAbsolutePath}'")
+
+ withSQLConf(HiveUtils.CONVERT_METASTORE_PARQUET.key -> "false",
+ "hive.exec.dynamic.partition.mode" -> "nonstrict") {
+ val insertSQL =
+ """
+ |INSERT OVERWRITE TABLE test PARTITION(p1='n1', p2)
+ |SELECT * FROM VALUES (1, 'n2'), (2, 'n3'), (3, 'n4') AS t(id,
p2)
+ """.stripMargin
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
