sunchao commented on a change in pull request #34431:
URL: https://github.com/apache/spark/pull/34431#discussion_r744294803
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HivePartitionFilteringSuite.scala
##########
@@ -62,6 +63,9 @@ class HivePartitionFilteringSuite(version: String)
properties = Map.empty
)
+ // Avoid repeatedly constructing multiple hive instances that do not use
direct sql
+ private var disableDirectSqlClient: HiveClient = _
Review comment:
Got it, thanks. One nit: could you rename `disableDirectSqlClient` to
something like `clientWithoutDirectSql`? the former looks like a boolean flag :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
