HyukjinKwon commented on a change in pull request #34273:
URL: https://github.com/apache/spark/pull/34273#discussion_r745223322
##########
File path: examples/src/main/python/avro_inputformat.py
##########
@@ -75,7 +75,7 @@
schema_rdd = sc.textFile(sys.argv[2], 1).collect()
conf = {"avro.schema.input.key": reduce(lambda x, y: x + y,
schema_rdd)}
- avro_rdd = sc.newAPIHadoopFile(
+ avro_rdd = sc.newAPIHadoopFile( # type: ignore[var-annotated]
Review comment:
It's good that mypy tests can pass on examples but I wonder if we can
remove such `ignore`. Examples are supposed to be verbose and close to the
standard. cc @srowen @holdenk FYI in case you have some opinions on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
