xuechendi commented on a change in pull request #34396:
URL: https://github.com/apache/spark/pull/34396#discussion_r745359478
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
##########
@@ -38,6 +43,29 @@
private final ArrowVectorAccessor accessor;
private ArrowColumnVector[] childColumns;
+ public static ArrowColumnVector[] loadColumns(StructType schema,
+ ArrowRecordBatch recordBatch) {
Review comment:
@BryanCutler, yes, the codes is very similiar because that is how arrow
designed to load ArrowRecordBatch to java List[Vector], do you mean I should
put this loadColumns function to ArrowConverters, and named as something like
<code>ArrowConverters.toColumnarBatchIterator : Iterator[ColumnarBatch]</code>
? I am OK to do that, I just felt it could fit in both scope, in
<code>ArrowConverters</code> or in <code>ArrowColumnVector</code>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
