cloud-fan commented on a change in pull request #33281:
URL: https://github.com/apache/spark/pull/33281#discussion_r746627392
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
##########
@@ -38,19 +41,41 @@ class EquivalentExpressions {
* Returns true if there was already a matching expression.
*/
def addExpr(expr: Expression): Boolean = {
- addExprToMap(expr, equivalenceMap)
+ updateExprInMap(expr, equivalenceMap)
}
- private def addExprToMap(
- expr: Expression, map: mutable.HashMap[ExpressionEquals,
ExpressionStats]): Boolean = {
+ /**
+ * Adds or removes an expression to/from the map and updates `useCount`.
Review comment:
how to indicate if we need to do add or remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
