venkata91 commented on a change in pull request #33896:
URL: https://github.com/apache/spark/pull/33896#discussion_r746929268
##########
File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala
##########
@@ -327,10 +338,32 @@ private[spark] class ShuffleBlockPusher(conf: SparkConf)
extends Logging {
s"stop.")
return false
} else {
+ if (remainingBlocks.isEmpty && pushRequests.isEmpty &&
deferredPushRequests.isEmpty) {
Review comment:
Wouldn't we add the blocks to `remainingBlocks` here when there are
multiple requests and so it won't be empty right when the `onBlockPushSuccess`
is triggered for the first request so `updateStateAndCheckIfPushMore` is still
referencing the same `Set` so it won't be empty right? Am I missing something
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
