Ngone51 commented on pull request #33872: URL: https://github.com/apache/spark/pull/33872#issuecomment-966306529
https://github.com/apache/spark/blob/9b96b705b2cce403ba5339cd481648c19bec5147/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala#L47-L48 Actually, all the states in `TaskSetManager` are already protected by `TaskSchudlerImpl`. So, `TaskSetManager.taskInfos` is actually thread-safe. I also confirmed it by checking the call chain around `handleSuccessfulTask` and `executorLost`. Therefore, we don't need extra protection on the `TaskSetManager.taskInfos`. @sleep1661 Would you like to continue working on this? Otherwise, I could take it over. BTW, I think we need a separate JIRA ticket for it since the real issue isn't the hanging issue and fix in a separate PR as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
