zero323 commented on pull request #34555: URL: https://github.com/apache/spark/pull/34555#issuecomment-966740024
> This type hint stuff are actually something boundary between Improvement and Bug. For example, with incorrect type hints, IDE would warn that the types and arguments are mismatched. With correct type hints, it won't warn anymore. That's also my reasoning behind marking it as an Improvement not a Bug. In many ways, we used to treat hints fixes more like documentation changes, than code changes until now, though current migration is most likely to change that. > While I think it's fine to don't backport since is only for internal purpose, It is not indicated as internal and in fact there are known public usages outside Spark (and likely, private as well). In general, we used to routinely backport simple annotation changes until now, because of non-intrusive character and borderline bug characteristic. If this was detected separately from SPARK-36845, I'd expect it would be handled the same way. That being said, I don't have strong opinion about this ‒ if consensus here is to mark it as wontfix, I am OK with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
