Peng-Lei commented on a change in pull request #34494:
URL: https://github.com/apache/spark/pull/34494#discussion_r748045155
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -598,6 +606,15 @@ abstract class CastBase extends UnaryExpression with
TimeZoneAwareExpression wit
IntervalUtils.castStringToYMInterval(s, it.startField, it.endField))
case _: YearMonthIntervalType => buildCast[Int](_, s =>
IntervalUtils.periodToMonths(IntervalUtils.monthsToPeriod(s),
it.endField))
+ case x: IntegralType if it.startField == it.endField =>
+ b =>
+ val intValue = try {
+ x.exactNumeric.asInstanceOf[Numeric[Any]].toInt(b)
Review comment:
make sense. It's a little weird `intToYearMonthInterval` take a
parameter of long type. So I want to change the method name:
`intToYearMonthInterval` => `integralToYearMonthInterval` and
`longToDayTimeInterval` => `integralToDayTimeInterval`. Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
